Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

swarm metrics: connection counting seems broken #2113

Closed
Tracked by #2062
marten-seemann opened this issue Feb 17, 2023 · 1 comment · Fixed by #2131
Closed
Tracked by #2062

swarm metrics: connection counting seems broken #2113

marten-seemann opened this issue Feb 17, 2023 · 1 comment · Fixed by #2131
Labels
help wanted Seeking public contribution on this issue kind/bug A bug in existing code (including security flaws) P1 High: Likely tackled by core team if no one steps up

Comments

@marten-seemann
Copy link
Contributor

image

While at the same time:

❯ ipfs swarm peers | wc
   1487    1487  135713

config:

  "Swarm": {
    "AddrFilters": null,
    "ConnMgr": {
      "GracePeriod": "20s",
      "HighWater": 1500,
      "LowWater": 900,
      "Type": "basic"
    },
@marten-seemann marten-seemann added kind/bug A bug in existing code (including security flaws) help wanted Seeking public contribution on this issue P1 High: Likely tackled by core team if no one steps up labels Feb 17, 2023
@marten-seemann marten-seemann mentioned this issue Feb 17, 2023
25 tasks
@sukunrt
Copy link
Member

sukunrt commented Feb 17, 2023

Do you have a long running node?
On my setup the primary source of divergence is MetricsTracer.ClosedConnection not being called when two dials succeed and one of them is dropped here

We can just call MetricsTracer.ClosedConnection there or we can move the OpenedConnection call to swarm.addConn

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Seeking public contribution on this issue kind/bug A bug in existing code (including security flaws) P1 High: Likely tackled by core team if no one steps up
Projects
None yet
2 participants