Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

autorelay: flaky TestWaitForCandidates #1384

Closed
marten-seemann opened this issue Apr 10, 2022 · 3 comments
Closed

autorelay: flaky TestWaitForCandidates #1384

marten-seemann opened this issue Apr 10, 2022 · 3 comments
Labels
kind/bug A bug in existing code (including security flaws)

Comments

@marten-seemann
Copy link
Contributor 

=== RUN   TestWaitForCandidates
      autorelay_test.go:176: 
          	Error Trace:	autorelay_test.go:176
          	Error:      	Condition never satisfied
          	Test:       	TestWaitForCandidates
  --- FAIL: TestWaitForCandidates (4.69s)
@marten-seemann marten-seemann added the kind/bug A bug in existing code (including security flaws) label Apr 10, 2022
@marten-seemann
Copy link
Contributor Author

Managed to get a failure with a log trace:

=== RUN   TestWaitForCandidates
2022-04-22T17:30:14.004+0100	DEBUG	autorelay	autorelay/relay_finder.go:587	starting relay finder
2022-04-22T17:30:14.156+0100	DEBUG	autorelay	autorelay/relay_finder.go:182	found node	{"id": "QmRUcxbiw2Un1YSoEfrRX5JDWNrDdPmqFHcDcC5fKcVCHf"}
2022-04-22T17:30:14.160+0100	DEBUG	autorelay	autorelay/relay_finder.go:224	node QmRUcxbiw2Un1YSoEfrRX5JDWNrDdPmqFHcDcC5fKcVCHf not accepted as a candidate: doesn't speak circuit v2
2022-04-22T17:30:14.454+0100	DEBUG	autorelay	autorelay/relay_finder.go:182	found node	{"id": "QmYABwYVqF4TUEEGMEUmkveqmFfX3UMS2iqnJjNvRCPF5t"}
2022-04-22T17:30:14.457+0100	DEBUG	autorelay	autorelay/relay_finder.go:232	node supports relay protocol	{"peer": "QmYABwYVqF4TUEEGMEUmkveqmFfX3UMS2iqnJjNvRCPF5t", "supports circuit v2": true}
    autorelay_test.go:199: 
        	Error Trace:	autorelay_test.go:199
        	Error:      	Condition never satisfied
        	Test:       	TestWaitForCandidates
2022-04-22T17:30:17.455+0100	DEBUG	autorelay	autorelay/relay_finder.go:599	stopping relay finder
--- FAIL: TestWaitForCandidates (3.59s)

@marten-seemann marten-seemann mentioned this issue Apr 22, 2022
Closed
@marten-seemann
Copy link
Contributor Author

And another, unrelated one:

=== RUN   TestWaitForCandidates
2022-04-22T18:37:46.677+0100	DEBUG	autorelay	autorelay/relay_finder.go:587	starting relay finder
2022-04-22T18:37:46.968+0100	DEBUG	autorelay	autorelay/relay_finder.go:182	found node	{"id": "QmWnykjv5AVsRsSxkMayLo4zt3H5tdW4AFNZZPz11bXMoW"}
2022-04-22T18:37:46.970+0100	DEBUG	autorelay	autorelay/relay_finder.go:232	node supports relay protocol	{"peer": "QmWnykjv5AVsRsSxkMayLo4zt3H5tdW4AFNZZPz11bXMoW", "supports circuit v2": true}
2022-04-22T18:37:47.428+0100	DEBUG	autorelay	autorelay/relay_finder.go:182	found node	{"id": "QmdajAAkmZvhA6iitMBVjSYh7hEdvzJ9hcMV6izpTF4ZW2"}
2022-04-22T18:37:47.431+0100	DEBUG	autorelay	autorelay/relay_finder.go:232	node supports relay protocol	{"peer": "QmdajAAkmZvhA6iitMBVjSYh7hEdvzJ9hcMV6izpTF4ZW2", "supports circuit v2": true}
    autorelay_test.go:211: 
        	Error Trace:	autorelay_test.go:211
        	Error:      	Condition never satisfied
        	Test:       	TestWaitForCandidates
2022-04-22T18:38:02.633+0100	DEBUG	autorelay	autorelay/relay_finder.go:599	stopping relay finder
2022-04-22T18:38:02.762+0100	DEBUG	autorelay	autorelay/relay_finder.go:378	adding new relay	{"id": "QmWnykjv5AVsRsSxkMayLo4zt3H5tdW4AFNZZPz11bXMoW"}
--- FAIL: TestWaitForCandidates (3.99s)

@marten-seemann marten-seemann changed the title flaky TestWaitForCandidates autorelay: flaky TestWaitForCandidates May 15, 2022
@MarcoPolo MarcoPolo mentioned this issue May 18, 2022
Closed
@marten-seemann
Copy link
Contributor Author

Fixed by #2120.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/bug A bug in existing code (including security flaws)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix flaky autorelay tests libp2p/go-libp2p
1 participant
@marten-seemann