Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: topicscore params can't be set for dynamically subscribed topic #540

Merged
merged 2 commits into from
Aug 19, 2023
Merged

fix: topicscore params can't be set for dynamically subscribed topic #540

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7da7423
fix: topicscore params can't be set for a topic subscribed after goss…
chaitanyaprem Aug 18, 2023
5ad905c
chore:address review comments
chaitanyaprem Aug 19, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 1 addition & 5 deletions score.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -202,13 +202,9 @@ func (ps *peerScore) SetTopicScoreParams(topic string, p *TopicScoreParams) erro
ps.Lock()
defer ps.Unlock()

old, exist := ps.params.Topics[topic]
old, _ := ps.params.Topics[topic]
chaitanyaprem marked this conversation as resolved.
Show resolved Hide resolved
ps.params.Topics[topic] = p

if !exist {
return nil
}

// check to see if the counter Caps are being lowered; if that's the case we need to recap them
recap := false
if p.FirstMessageDeliveriesCap < old.FirstMessageDeliveriesCap {
Expand Down