fix unused GossipSubHistoryGossip, make seenMessages ttl configurable #484
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…, make score params SeenMsgTTL configurable
vyzo
approved these changes
May 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a few minor issues:
GossipSubHistoryGossipglobal was unused, the config was defaultingHistoryGossipto the sameGossipSubHistoryLengthasHistoryLengthseenMessagescache TTL configurable without having to change the global. Eth2 and optimism both customize this differently, it should not only just be a global var.PeerScoreParamsnot use the globalTimeCacheDurationby adding a SeenMsgTTL field. It will default to the global value if the new field is not specified, so no breaking changes.