Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Topic() method to Topic struct. #370

Merged
merged 1 commit into from
Aug 11, 2020
Merged

Add Topic() method to Topic struct. #370

merged 1 commit into from
Aug 11, 2020

Conversation

lthibault
Copy link
Contributor

Fixes #358 and part of #198.

@lthibault lthibault mentioned this pull request Aug 3, 2020
Closed
@aschmahmann
Copy link
Contributor

@vyzo you good with merging this?

@vyzo
Copy link
Collaborator

vyzo commented Aug 10, 2020

We want a String() method I think, but I am not going to block it.

@lthibault
Copy link
Contributor Author

@vyzo I initially used Topic because it is used by Subscription, but I actually agree that String is better.

Shall I make the change?

@vyzo
Copy link
Collaborator

vyzo commented Aug 10, 2020

yes please!

@lthibault
Copy link
Contributor Author

@vyzo Done!

vyzo
vyzo approved these changes Aug 11, 2020
View reviewed changes
Copy link
Collaborator

@vyzo vyzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you!

@vyzo vyzo merged commit c5ece1d into libp2p:master Aug 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vyzo vyzo vyzo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

pubsub.Topic should satisfy fmt.Stringer
3 participants
@lthibault @aschmahmann @vyzo