Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

only do PX on leave if PX was enabled in the node #353

Merged
merged 1 commit into from
Jun 15, 2020
Merged

only do PX on leave if PX was enabled in the node #353

merged 1 commit into from
Jun 15, 2020

Conversation

vyzo
Copy link
Collaborator

@vyzo vyzo commented Jun 15, 2020

Closes #349

@vyzo vyzo mentioned this pull request Jun 15, 2020
Closed
aschmahmann
aschmahmann approved these changes Jun 15, 2020
View reviewed changes
Copy link
Contributor

@aschmahmann aschmahmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable to me.

@vyzo vyzo merged commit 8945f91 into master Jun 15, 2020
@vyzo vyzo deleted the fix/issue-349 branch June 15, 2020 07:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aschmahmann aschmahmann aschmahmann approved these changes

@yusefnapora yusefnapora Awaiting requested review from yusefnapora

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Question: is pubsub discovery enabled by default (or some parts of it)
2 participants
@vyzo @aschmahmann