Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some tests timing out #90

Open
guseggert opened this issue Nov 22, 2021 · 1 comment
Open

Some tests timing out #90

guseggert opened this issue Nov 22, 2021 · 1 comment

Comments

@guseggert
Copy link
Contributor

This seems to be getting progressively worse over time...some tests are hanging and timing out waiting for propagation, see e.g. this run:

https://github.com/libp2p/go-libp2p-pubsub-router/runs/4035361341?check_suite_focus=true

@galargh
Copy link
Contributor

galargh commented Jan 14, 2022

I think it might be because of

rebroadcastInterval: time.Minute * 10,
. I don't know what the setting does exactly but it seems the tests either succeed after around 1 minute or 11 minutes.

To make the checks pass I have increased the go test timeout to 20 minutes - 9977e77

My commit can be reverted once the tests are able to configure rebroadcastInterval (assuming my guess is correct of course).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants