Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add validation of SdkUds to CSI Server #971

Merged

Conversation

ggriffiths
Copy link
Contributor

Signed-off-by: Grant Griffiths [email protected]

What this PR does / why we need it:

  • CSI->SDK Was timing out. This was caused because SdkUds was not set in the OsdCsiServerConfig.
  • We should err out on NewOsdCsiServer if this is not set.

Which issue(s) this PR fixes (optional)
Closes #970

Special notes for your reviewer:

@ggriffiths ggriffiths force-pushed the csi_server_validate_sdkuds branch from deab47f to 02662fa Compare March 21, 2019 22:14
@ggriffiths ggriffiths requested a review from lpabon March 21, 2019 22:27
@ggriffiths ggriffiths merged commit 61b597c into libopenstorage:master Mar 22, 2019
@ggriffiths ggriffiths deleted the csi_server_validate_sdkuds branch March 22, 2019 21:41
ggriffiths added a commit to ggriffiths/openstorage that referenced this pull request Mar 22, 2019
ggriffiths added a commit that referenced this pull request Mar 22, 2019
release-6.0: Add validation of SdkUds to CSI Server (#971)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CSI Server's SdkUds is not being validated
2 participants