Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Audit for existing casting/nil/panic vulnerabilities #96

Closed
bufdev opened this issue Dec 16, 2015 · 2 comments
Closed

Audit for existing casting/nil/panic vulnerabilities #96

bufdev opened this issue Dec 16, 2015 · 2 comments
Labels
discuss kind/cleanup
Milestone
v1.1

Comments

@bufdev
Copy link
Contributor

bufdev commented Dec 16, 2015

Example:

openstorage/cluster/manager.go

Line 149 in 8d07329

logrus.Warnf("Failed to initialize %s: %v",

  • How are we sure that e.Value is not nil?
  • How are we sure that e.Value can be case to ClusterManager?

Both of these should be checked, ie e.Value == nil -> error, clusterManager, ok := e.Value.(ClusterManager)
@bufdev bufdev mentioned this issue Dec 16, 2015
Closed
@jvinod
Copy link
Contributor

jvinod commented Dec 17, 2015

agreed, let's find these occurrences and fix them.

@erickhan erickhan added this to the v1.1 milestone Mar 8, 2017
@lpabon
Copy link
Contributor

lpabon commented Nov 13, 2017

Closing since it has had no update for more than 6 months. Please reopen if needed.

@lpabon lpabon closed this as completed Nov 13, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
discuss kind/cleanup
Projects
None yet
Milestone
v1.1
Development

No branches or pull requests
4 participants
@lpabon @bufdev @erickhan @jvinod