Update cloud migrate group backup access denied message #1258
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
talakad
reviewed
Oct 1, 2019
api/server/sdk/cloud_backup.go
Outdated
| @@ -133,7 +134,11 @@ func (s *CloudBackupServer) GroupCreate( | |||
|
|
|||
| // Check ownership for this intersection | |||
| if err := checkAccessFromDriverForVolumeIds(ctx, s.driver(ctx), volumesToCheck, api.Ownership_Read); err != nil { | |||
| return nil, err | |||
| if err == kvdb.ErrNotFound { | |||
There was a problem hiding this comment.
checkAccessFromDriverForVolume returns "codes.PermissionDenied" for access errors. Perhaps we should check for that and return other errors as is?
Actually that function returns "codes.NotFound" instead of kvdb.ErrNotFound.
There was a problem hiding this comment.
checkAccessFromDriverForVolumeIds is used by other functions, so I don't want to return the error about GroupIDs there.
But yeah I'll change the caller to check for codes.NotFound instead.
ggriffiths
force-pushed
the
errormsg_cloudbackup_create_group
branch
from
8e92f91 to
6f7831f
Compare
talakad
approved these changes
Oct 1, 2019
Signed-off-by: Grant Griffiths <[email protected]>
ggriffiths
force-pushed
the
errormsg_cloudbackup_create_group
branch
from
6f7831f to
3b1354a
Compare
This was referenced Oct 2, 2019
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Grant Griffiths [email protected]
What this PR does / why we need it:
Updates the error message for cloud backup group create when a user does not have access to a volume in a group.
Which issue(s) this PR fixes (optional)
Closes #1257
Special notes for your reviewer: