Add remaining secrets providers for auth token_secret support #1196
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ggriffiths
force-pushed
the
add_remaining_secrets_providers
branch
4 times, most recently
from
d9c19f3 to
98c95a7
Compare
Signed-off-by: Grant Griffiths <[email protected]>
ggriffiths
force-pushed
the
add_remaining_secrets_providers
branch
from
98c95a7 to
e093999
Compare
adityadani
approved these changes
Aug 20, 2019
ggriffiths
added a commit
to ggriffiths/openstorage
that referenced
this pull request
Aug 20, 2019
…#1196) Signed-off-by: Grant Griffiths <[email protected]>
ggriffiths
added a commit
to ggriffiths/openstorage
that referenced
this pull request
Aug 20, 2019
…#1196) Signed-off-by: Grant Griffiths <[email protected]>
ggriffiths
added a commit
that referenced
this pull request
Aug 22, 2019
Signed-off-by: Grant Griffiths <[email protected]>
ggriffiths
added a commit
that referenced
this pull request
Aug 22, 2019
Signed-off-by: Grant Griffiths <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Grant Griffiths [email protected]
What this PR does / why we need it:
Which issue(s) this PR fixes (optional)
Closes #1195
Special notes for your reviewer:
pkg/auth/secretsto only use a singleAuthstruct, as the implementation for each cloud provider seemed very similar. For providers that have edge cases (DCOS/K8s), we handle those inAuth.GetToken()api/spec/spec_handler.goto allow for these fields to be passed in and parsed.