Add cloud group backup API to SDK #1130
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ggriffiths
changed the title
ggriffiths
force-pushed
the
sdk_cloud_group_backup
branch
from
180963f to
169ca29
Compare
talakad
reviewed
Jun 3, 2019
api/server/sdk/cloud_backup.go
Outdated
| } | ||
| credId := req.GetCredentialId() | ||
| var err error | ||
| if len(req.GetGroupId()) == 0 && len(req.GetVolumeIds()) == 0 { |
There was a problem hiding this comment.
users could request group cloud backups for volumes with matching labels. Check needs to include nil labels as well.
talakad
reviewed
Jun 3, 2019
|
|
||
| // Check ownership for all volume IDs | ||
| if len(req.GetVolumeIds()) > 0 { | ||
| if err := checkAccessFromDriverForVolumeIds(ctx, s.driver(ctx), req.GetVolumeIds(), api.Ownership_Read); err != nil { |
There was a problem hiding this comment.
these checks need to consider labels and group id as well.
talakad
reviewed
Jun 3, 2019
api/server/sdk/cloud_backup.go
Outdated
|
|
||
| // Check ownership for group ID | ||
| if len(req.GetGroupId()) > 0 { | ||
| if err := checkAccessFromDriverForGroupId(ctx, s.driver(ctx), req.GetGroupId(), api.Ownership_Read); err != nil { |
There was a problem hiding this comment.
This should include labels and must be done only len(req.GetVolumeIds() ==0.
talakad
reviewed
Jun 3, 2019
| return nil, err | ||
| } | ||
| } | ||
|
|
There was a problem hiding this comment.
If both groupID and volume list is not specified and only labels are provided, permissions perhaps should be checked for those volumes with matching labels?
ggriffiths
force-pushed
the
sdk_cloud_group_backup
branch
4 times, most recently
from
1ee691d to
b34cb1b
Compare
talakad
reviewed
Jun 4, 2019
| } | ||
|
|
||
| switch { | ||
| // VolumeIDs and at least a GroupID or Labels are provided. Get filtered volumes based on GroupID and/or Labels, |
Signed-off-by: Grant Griffiths <[email protected]>
ggriffiths
force-pushed
the
sdk_cloud_group_backup
branch
from
b34cb1b to
f179b6e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR adds support for Cloud group backup in the SDK Server
Which issue(s) this PR fixes (optional)
Closes #1129
Special notes for your reviewer:
I have made the following two assumptions regarding ownership:
If userA has access to 25 volumes inside a
GroupA, and asks userB to backupGroupA, but userB only has access to 5 out of the 25 volumes, it would be dangerous to only backup those 5 volumes. This is because UserA asked for a backup of all of GroupA, but userB only has partial access to the volumes in that group. Returning successfully in this case would give UserB false confidence that the entirety of GroupA has been backed up.