Check for ownership on migrate cancel and status #1099
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ggriffiths
force-pushed
the
cloud_migration_ownership
branch
2 times, most recently
from
2b522f5 to
9c1492e
Compare
ggriffiths
commented
May 2, 2019
ggriffiths
force-pushed
the
cloud_migration_ownership
branch
7 times, most recently
from
4e5c2d1 to
2b67287
Compare
lpabon
requested changes
May 15, 2019
ggriffiths
force-pushed
the
cloud_migration_ownership
branch
from
2b67287 to
b446805
Compare
talakad
reviewed
May 15, 2019
| for _, cluster := range resp.Info { | ||
| for _, migrateInfo := range cluster.List { | ||
| if err := checkAccessFromDriverForVolumeId(ctx, s.driver(ctx), | ||
| migrateInfo.GetLocalVolumeId(), api.Ownership_Read); err != nil { |
There was a problem hiding this comment.
Shouldn't this be api.OwnershipWrite? since the check is being used for cancel?
There was a problem hiding this comment.
I can change it to that, but anyone with Read Access can start a migration for that volume, so I figured that delete/status should match that.
Let me see what Bhavana and Luis think.
talakad
approved these changes
May 15, 2019
Signed-off-by: Grant Griffiths <[email protected]>
ggriffiths
force-pushed
the
cloud_migration_ownership
branch
from
b446805 to
0d4fdf9
Compare
|
Just re-tested this on two px clusters with the latest changes - works as expected. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Grant Griffiths [email protected]
What this PR does / why we need it:
Which issue(s) this PR fixes (optional)
Closes #1098
Special notes for your reviewer: