Add support for SDK gRPC server extension callbacks #1094
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lpabon
approved these changes
May 1, 2019
| @@ -107,6 +107,10 @@ type ServerConfig struct { | |||
| StoragePolicy policy.PolicyManager | |||
| // Security configuration | |||
| Security *SecurityConfig | |||
| // ServerExtensions allow extending the SDK gRPC server | |||
| // with callback functions that are executed in order | |||
| // at the end of Server.Start() | |||
There was a problem hiding this comment.
Thanks. I think you should add a small comment to showing an example of how it can be used. Then merge it
Signed-off-by: Grant Griffiths <[email protected]>
ggriffiths
force-pushed
the
add_sdk_server_extension
branch
from
cd80c9b to
50df47a
Compare
ggriffiths
added a commit
to ggriffiths/openstorage
that referenced
this pull request
May 13, 2019
Signed-off-by: Grant Griffiths <[email protected]>
ggriffiths
added a commit
to ggriffiths/openstorage
that referenced
this pull request
Aug 1, 2019
Signed-off-by: Grant Griffiths <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Grant Griffiths [email protected]
What this PR does / why we need it:
Which issue(s) this PR fixes (optional)
Closes #1093
Special notes for your reviewer: