Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add RID-aware AssemblyLoadContext package #1649

Open
bording opened this issue Dec 11, 2018 · 0 comments
Open

Add RID-aware AssemblyLoadContext package #1649

bording opened this issue Dec 11, 2018 · 0 comments

Comments

@bording
Copy link
Member

bording commented Dec 11, 2018

In order to make it easier for people to use LibGit2Sharp from something like an MSBuild task, we should consider adding a separate package that contains a custom AssemblyLoadContext with logic can properly load the right assembly based on the RID of the system. I'm thinking this could be named something like LibGit2Sharp.AssemblyLoadContext.

Doing something like this would be we could update the package as needed whenever we have a change in the set of native binaries.

@tmat Would it be possible to do something like move the code you've written for SourceLink into this proposed package instead? It would be nice to have that in a centralized place for everyone to use, and it would remove the burden on you to know when the RID mappings needed to be updated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant