-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Completion_fields: Enable the storing of payloads, defaults to false #25
Comments
I like the idea and it seems straightforward if we just switch from false to true, since we return the data almost as is anyway. But it gets a little bit trickier if we need to provide the option. |
Well, this is exactly what I need now. |
Hello, Nobody is working on this at the moment because even though it works pretty well out of the box and is well battle tested, the number of implemented features is too narrow to make it usable in most cases but the most basic ones, and the amount of work to change that is still quite substantial for one individual :) |
I tried this, but there must be something obvious I'm missing.
Not sure if I need the extra mapping field, or not.
|
Well i can't really test it now but maybe there is something to change in the complete() method, or add some logging and check what elaticsearch returns. |
complete is an awesome api. However lack of payload (basically document id) renders it useless for many usecases.
Basically: Enable the storing of payloads, it defaults to false.
For example:
a. Tag.es.complete('name', 'p')
[u'Play/Outdoor', u'Performing Arts', u'Personality', u'Phonetics', u'Phonics']
b. City.es.complete('city', 'n')
[u'New Delhi']
However, without payload (document id's) its not usable for multiple usecases where the id is passed along to the client/in the workflow.
Checked the mappings for a connection_field city:
"city_complete": {
"max_input_length": 50,
"payloads": false,
"analyzer": "simple",
"preserve_position_increments": true,
"type": "completion",
"preserve_separators": true
},
The text was updated successfully, but these errors were encountered: