Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Py3 compatibility #12

Open
jmaupetit opened this issue May 24, 2015 · 7 comments
Open

Py3 compatibility #12

jmaupetit opened this issue May 24, 2015 · 7 comments

Comments

@jmaupetit
Copy link

Thank you for this work! I tried django-elasticsearch with python 3 and "patatras" I realized that it's restricted to python 2.x

I think your approach is relevant and, if interested, I may help you porting this app to python3.

Tell me.

@lauxley
Copy link
Contributor

lauxley commented May 26, 2015

Hi, thanks for your interest,
The python3 compatibility would be rad ! My only worry is about unit tests, there is already 4 django versions to test, python3 would double that number, but please go ahead, I'll bundle the tests with nose or something.

@jmaupetit
Copy link
Author

Ok i'll give some impulse for python 3. Concerning unit tests, have you considered using tox to automatize application testing with multiple django and python releases?

@lauxley
Copy link
Contributor

lauxley commented May 26, 2015

I actually made a PR with tox this morning #13, you can base yours on the branch feature/tox-tests-bundle. Or even add to it since I don't really see the point in merging it before making tests pass with python3, and we can rename the PR if need be.

@jmaupetit
Copy link
Author

Ok. I'll take a look by the end of the week.

@leotsem
Copy link

leotsem commented Nov 28, 2015

Is anyone currently working on Py3 support?

@lauxley
Copy link
Contributor

lauxley commented Dec 1, 2015

Not that i know of, i have a very early branch using 2to3 but it's not even worth sharing at that point, and i won't be back to it until January.

@jmaupetit
Copy link
Author

My bad. Damned what appended since May? What a very long week :) @leotsem do you plan to work on it soon?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants