-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: Add workflow to build and issue static binaries #84
Conversation
4fe9758
to
749e359
Compare
Example of workflow with the tests running. (I removed the cache thingy) |
Thanks a ton for this workflow!! |
c912ecf
to
a6d0e07
Compare
Hey! I think I addressed your feedback. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Please find some comments in the discussions above, and one more nit below.
The workflow builds natively for amd64 with LLVM library and use emulation to build for arm64 with LLVM as well. The result are two static binaries with their respective compressed archives. Signed-off-by: Mahe Tardy <[email protected]>
a6d0e07
to
6150fa4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything looks in order, thanks again!
Do you have a final test run to confirm that $(HOSTAR)
behaves as expected?
Yep it does work! perfect! |
Right I found this test, OK thanks a lot! |
The workflow builds natively for amd64 with LLVM library and use emulation to build for arm64 with LLVM as well. The result are two static binaries with their respective compressed archives.
You can see how the workflow acts on my fork, and how the result release page looks (the release has been published here, the action just creates a draft).
Honestly, GitHub action and cross-compilation/emulation (I tried both) were a bit hard to get right with the LLVM library, it took me something like 10 hours and 70 attempts + all the tests locally on amd64 and arm64.