Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

git module's clean_bg/dirty_bg don't seem to work properly #5

Closed
dmolin opened this issue Mar 25, 2022 · 2 comments
Closed

git module's clean_bg/dirty_bg don't seem to work properly #5

dmolin opened this issue Mar 25, 2022 · 2 comments

Comments

@dmolin
Copy link
Contributor

dmolin commented Mar 25, 2022

Not sure if it's me but I cannot make clean_bg and dirty_bg to work properly in the git module. It seems the color is only applied to the path separator at the end of the current folder (see image, where I set the dirty_bg color to green for the git and the current project has an untracked file)

As an example, this code:

 type: git
  clean_bg: "#279a43"
  dirty_bg: "#772222"
  clean_fg: "#7ceb07"
  dirty_fg: "#efe310"

Gives me this when there are no changes:

2022-03-25_06-56

(The blue you see is the background of my terminal window)
clean_fg and dirty_fg instead works perfectly and as intended.

I believe the proble is in modules/git.go at lines 60 and 63, where the function called should be e.mc.Bg() instead of e.mc.Fg(). I've issued a PR

OS: Manjaro Linux
Shell: bash

@liamg
Copy link
Owner

liamg commented Mar 25, 2022

Thanks @dmolin - I’ll patch this when I’m at my desk in an hour or so 👍

@liamg
Copy link
Owner

liamg commented Mar 25, 2022

Fixed in #6 - thank you!

@liamg liamg closed this as completed Mar 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants