Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TypeError: Cannot read property 'target' of undefined #63

Closed
Akrion opened this issue Mar 31, 2015 · 1 comment
Closed

TypeError: Cannot read property 'target' of undefined #63

Akrion opened this issue Mar 31, 2015 · 1 comment

Comments

@Akrion
Copy link

Akrion commented Mar 31, 2015

After your latest update the call to

$(element).find(args).matchHeight();

fails with "TypeError: Cannot read property 'target' of undefined "

The workaround was to call with an empty object like this:

$(element).find(args).matchHeight({});

Bug is in your check for target (line 114)

if (this.length <= 1 && !options.target) {
   return this;
}

Also anyway you can tag your releases so we do not blindly use master (I need the min-height feature)?

As always thanks you for your work and for sharing this.

@liabru liabru closed this as completed in 290dfcf Mar 31, 2015
@liabru
Copy link
Owner

liabru commented Mar 31, 2015

Apologies. That should sort it. I'll get a new release arranged!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants