Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GFF3 output is malformed for stop_codon features #55

Closed
carsonhh opened this issue Jan 16, 2024 · 1 comment
Closed

GFF3 output is malformed for stop_codon features #55

carsonhh opened this issue Jan 16, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@carsonhh
Copy link

carsonhh commented Jan 16, 2024

Miniprot output when set to --gff produces CDS and stop_codon features; however, the stop_codon is being produced as being excluded from the CDS based on its coordinates rather than overlapping the CDS. The GFF3 spec and Sequence Ontology specify that the stop codon is part of the CDS, and when added a stop_codon feature would be expected to overlap the CDS coordinates http://sequenceontology.org/browser/release_2.5.3/term/SO:0000316

This is the current output:
Chr01 miniprot mRNA 132416083 132416229 216 + . ID=MP000276
Chr07 miniprot CDS 132416083 132416226 216 + 0 Parent=MP000276
Chr07 miniprot stop_codon 132416227 132416229 0 + 0 Parent=MP000276

The correct output would be as follows:
Chr01 miniprot mRNA 132416083 132416229 216 + . ID=MP000276
Chr07 miniprot CDS 132416083 132416229 216 + 0 Parent=MP000276
Chr07 miniprot stop_codon 132416227 132416229 0 + 0 Parent=MP000276

Note the stop codon position is now part of the CDS, and any separate stop_codon feature line will overlap the CDS for the three base pairs comprising the codon. Also note that GTF and GFF3 differ in this respect. In GTF the stop codon is excluded from the CDS, but in GFF3 it is included. This is because GFF3 specifically follows the rules of the Sequence Ontology for feature organization.

@lh3 lh3 added the bug Something isn't working label Mar 6, 2024
@lh3 lh3 closed this as completed in 61a352f Mar 6, 2024
@lh3
Copy link
Owner

lh3 commented Mar 6, 2024

Thanks. Fixed on github HEAD.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants