Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Seg fault with improper arguments #4

Closed
twrightsman opened this issue Sep 13, 2022 · 3 comments
Closed

Seg fault with improper arguments #4

twrightsman opened this issue Sep 13, 2022 · 3 comments
Labels
bug Something isn't working

Comments

@twrightsman
Copy link

I accidentally used the -d option while attempting to do alignment and miniprot segfaulted instead of printing an error message.

$ miniprot --version
0.2-r116
$ miniprot -t8 -d genome.mpi query.faa.gz > aln.paf
[M::[email protected]*1.01] read 20843494 bases in 48265 contigs
[M::[email protected]*1.01] 210726 blocks
[M::[email protected]*3.88] collected syncmers
Segmentation fault
@lh3 lh3 added the bug Something isn't working label Sep 13, 2022
@lh3
Copy link
Owner

lh3 commented Sep 13, 2022

Thanks. Fully agree that miniprot should report an error rather than segfault. Will have a look.

@lh3 lh3 closed this as completed in 99c013d Sep 14, 2022
@lh3
Copy link
Owner

lh3 commented Sep 14, 2022

Miniprot doesn't segfault now. However, it will parse proteins as if they are nucleotide sequences without outputting errors. Checking proteins vs nucleotides requires more work.

@silviaprietob
Copy link

Hello!
I think I might be having a similar issue to the one twrightsman had.
I accidentally used -gff instead of --gff when running miniprot, and now every time I try to run it with the correct option, miniprot returns a 'unrecogniszed option' and a Segmentation fault (core dumped) error.

`$ miniprot/miniprot -I --gff -outs=0.95 miniprot/genomicfastas/PHYGR.fa missingfastas/PHYGRmissing.fa > miniprotout/PHYGR.gff

[WARNING] unrecognized option: --gff
[M::[email protected]0.98] read 1373559025 bases in 460 contigs
[M::[email protected]
0.98] 10731402 blocks
Segmentation fault (core dumped)`

I don't think it's the memory either as I have given it up to 50 G.

Any ideas as to why this might be, how to fix it?

Thank you very much!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants