Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update makeGoSet doc #57

Open
lmsimp opened this issue Jul 15, 2015 · 4 comments
Open

Update makeGoSet doc #57

lmsimp opened this issue Jul 15, 2015 · 4 comments

Comments

@lmsimp
Copy link
Collaborator

lmsimp commented Jul 15, 2015

  • Add a note about GO hierarchy
  • Add a note/link about filterBinMSnSet
  • In paper: @lmsimp to complete
  • update TL vignette and load TL params rda file. Then remove then from andy2011.

Maybe also add a note in the vignette.

@lgatto
Copy link
Owner

lgatto commented Aug 20, 2016

@lmsimp - reminder about this issue: has these been done?

@lgatto
Copy link
Owner

lgatto commented Oct 18, 2024

There are major differences in the makeGoSet() example, that now returns only two GO terms. Not sure what happens. It might not be a problem, and just be the result of using old parameters to retrieve the terms, but I had to fix some examples. I am wondering if this GO functionality is still relevant and whether it could be deprecated. @lmsimp what do you think?

@lmsimp
Copy link
Collaborator Author

lmsimp commented Oct 18, 2024

I haven't used this functionality in a while now. Initial thoughts are yes... I will take a look and confirm.
If we were to remove makeGoSet would this allow removal of biomaRt from dependencies?

@lgatto
Copy link
Owner

lgatto commented Oct 19, 2024

The whole vignette annotation stuff gets dropped (vignette 4), and part of the transfer learning (vignette 5). It would be quite radical.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants