Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Code Review helper functions TAGM #117

Open
ococrook opened this issue Oct 31, 2018 · 1 comment
Open

Code Review helper functions TAGM #117

ococrook opened this issue Oct 31, 2018 · 1 comment
Assignees
@ococrook
Labels
enhancement

Comments

@ococrook
Copy link
Collaborator

Review code pushed in e4e45ca

current location https://github.com/lgatto/pRoloc/blob/master/R/machinelearning-functions-tagm-mcmc-helper.R
@ococrook ococrook self-assigned this Oct 31, 2018
@lgatto
Copy link
Owner

lgatto commented Jan 16, 2019

@ococrook I think it would be good to avoid accessing slots directly, such as params@posteriors@logposterior when plotting the log-poster at each iteration of the EM algorithm. There is also burntagmE14@chains@chains for which we already have an accessor. Any other examples you can think of?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ococrook ococrook

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@lgatto @ococrook