Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace validate with parse #10

Open
lfr opened this issue Feb 2, 2021 · 1 comment
Open

Replace validate with parse #10

lfr opened this issue Feb 2, 2021 · 1 comment

Comments

@lfr
Copy link
Owner

lfr commented Feb 2, 2021

I don't use this library (yet), but one thing that struck me when reading the readme is that this library isn't about validation, it's about parsing. See Parse, don't validate. If the API is about to be changed anyway, I suggest changing "validate" to "parse".

Strictly speaking, the ITextBlock.Validate method actually performs validation, not parsing. But stuff like Block.validate should be called Block.parse.


From @cmeeren #5

@lfr lfr mentioned this issue Feb 4, 2021
@ericdes
Copy link

ericdes commented Apr 9, 2021

Hello,
As a new user of your library (actually testing it if it fits my needs), I really think that "Parsing" reflects more what I'm doing than "Validating".

This is especially true on the domain level when converting a DTO to a model. Actually I'd also like to make modifications as well, e.g. triming a string when it's too long (rather than just validating it).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants