Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New feature: actix-web support #135

Closed
anxiousmodernman opened this issue Jun 11, 2018 · 1 comment
Closed

New feature: actix-web support #135

anxiousmodernman opened this issue Jun 11, 2018 · 1 comment

Comments

@anxiousmodernman
Copy link
Contributor

anxiousmodernman commented Jun 11, 2018 •
edited
Loading

I'm intrigued by the actix-web framework. It should be possible to implement their Responder trait and include it behind feature flag actix-web in the manner of Rocket or Iron.

Some documentation on responses in actix-web:

Note the associated types in Responder: Error and Item. We can use their Error type, although we never have to actually return it.
anxiousmodernman added a commit to anxiousmodernman/maud that referenced this issue Jun 11, 2018
@anxiousmodernman
Stub out (possible?) impl Responder for actix
7d04183 
It looks similar to the Rocket implementation, and functionally is also similar:
a static, syncronous response for PreEscaped<String>

Refs lambda-fairy#135
anxiousmodernman added a commit to anxiousmodernman/maud that referenced this issue Jun 11, 2018
@anxiousmodernman
Impl for String type parameter
b458ed8 
Refs lambda-fairy#135
anxiousmodernman added a commit to anxiousmodernman/maud that referenced this issue Jun 11, 2018
@anxiousmodernman
Working String implementation
8d91571 
Life's easy when you're on the heap. Refs lambda-fairy#135
@anxiousmodernman
Copy link
Contributor Author

maud_actix

anxiousmodernman added a commit to anxiousmodernman/maud that referenced this issue Jun 11, 2018
@anxiousmodernman
impl Responder for actix-web framework
0281555 
It looks similar to the Rocket implementation, and functionally is also similar:
a syncronous response for PreEscaped<String>

Refs lambda-fairy#135
anxiousmodernman added a commit to anxiousmodernman/maud that referenced this issue Jun 11, 2018
@anxiousmodernman
impl Responder for actix-web framework
ff86aea 
It looks similar to the Rocket implementation, and functionally is also similar:
a syncronous response for PreEscaped<String>

Refs lambda-fairy#135
@anxiousmodernman anxiousmodernman mentioned this issue Jun 11, 2018
Merged
anxiousmodernman added a commit to anxiousmodernman/maud that referenced this issue Jun 12, 2018
@anxiousmodernman
impl Responder for actix-web framework
5f608c7 
It looks similar to the Rocket implementation, and functionally is also similar:
a syncronous response for PreEscaped<String>

Refs lambda-fairy#135
lambda-fairy pushed a commit that referenced this issue Jun 15, 2018
@anxiousmodernman @lambda-fairy
impl Responder for actix-web framework
fd59814 
It looks similar to the Rocket implementation, and functionally is also similar:
a syncronous response for PreEscaped<String>

Refs #135
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@anxiousmodernman @lambda-fairy