-
Notifications
You must be signed in to change notification settings - Fork 144
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build error on nightly (2018-04-05) #121
Comments
Thanks for reporting. I'll look into it over the coming weekend. (Unless you'd like to do the upgrade instead 😉) |
Instead of a `kind` field containting a `TokenNode` variant, a TokenTree is not an enum with variants of different types. Note that a TokenTree could be a sequence of TokenTrees. Refs lambda-fairy#121
I'll give it a shot and take some notes here. It looks like a Not sure about an equivalent to |
Don't pass TokenStream::empty() here
Worked through A |
also: remove dead code remove invalid import Refs lambda-fairy#121
also: remove dead code remove invalid import Refs lambda-fairy#121
Use the `token_stream::FromIter` type to chain together the Option<TokenStream> types that `match_arm` yields. There may be a way to simplify this code. Refs lambda-fairy#121
I'm unsure about the set_span call, but I did not want to throw away the passed in Span. Refs lambda-fairy#121
It doesn't seem as easy to compose/chain TokenStreams as it is to collect a Vec<TokenTree> into a TokenStream. There is probably some iterator API I could use instead. Refs lambda-fairy#121
This compiles, but does not pass tests. Instead of a `kind` field containting a `TokenNode` variant, a TokenTree is now an enum with variants of different types (Literal, Op, Term, etc). Note that a TokenTree could be a sequence of TokenTrees if it is a Group variant. Other notes: I'm unsure about the set_span call in Builder::emit_if, but I did not want to throw away the passed in Span. Parsing relies on destructuring references to the values associated with TokenTree enum variants It doesn't seem as easy to compose/chain TokenStreams as it is to collect a Vec<TokenTree> into a TokenStream. There is probably some iterator API I could use instead. See `match_arms` and build.rs Refs lambda-fairy#121
This passes tests. Refs lambda-fairy#121
Instead of a `kind` field containting a `TokenNode` variant, a TokenTree is now an enum with variants of different types (Literal, Op, Term, etc). Note that a TokenTree could be a sequence of TokenTrees if it is a Group variant. Other notes: I'm unsure about the set_span call in Builder::emit_if, but I did not want to throw away the passed in Span. Parsing relies on destructuring references to the values associated with TokenTree enum variants It doesn't seem as easy to compose/chain TokenStreams as it is to collect a Vec<TokenTree> into a TokenStream. There is probably some iterator API I could use instead. See `match_arms` and build.rs Refs lambda-fairy#121
Instead of a `kind` field containting a `TokenNode` variant, a TokenTree is now an enum with variants of different types (Literal, Op, Term, etc). Note that a TokenTree could be a sequence of TokenTrees if it is a Group variant. Other notes: I'm unsure about the set_span call in Builder::emit_if, but I did not want to throw away the passed in Span. Parsing relies on destructuring references to the values associated with TokenTree enum variants It doesn't seem as easy to compose/chain TokenStreams as it is to collect a Vec<TokenTree> into a TokenStream. There is probably some iterator API I could use instead. See `match_arms` and build.rs Refs lambda-fairy#121
This might be fixed. Interested parties can try testing with my fork: # in Cargo.toml
[dependencies]
maud = { git = "https://github.com/anxiousmodernman/maud.git", branch = "121_proc_macro", features = ["rocket"] } Of course, you will need to list the particular features your project depends on. Also note that TOML wants this hash all on one line. |
Also remove conservative_impl_trait feature flag, as this is now a stable feature. Refs lambda-fairy#121
I'll leave my fork up for a while, but these changes are now in maud master. |
I'm doing a release build with
rocket
features. I get a big run of errors when compilingmaud_macros
. This is a pretty recent development, so I don't think it's due to any code change in maud itself.many other errors not shown
These are the most recent docs I can find for the
proc_macro
crate. It looks like major changes to the API.The text was updated successfully, but these errors were encountered: