Use functor map implementation for sequences when applicable #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
countvajhula
force-pushed
the
functor-sequence-priority
branch
from
0427be0 to
a3a35ab
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #11.
At the moment, it looks like
mapdelegates sequence input to thedata/collectionversion ofmapin order to leverage the "zip" behavior when more than one sequence input is provided, in which case the functor implementation would be inapplicable in any case. This fix modifies that condition to specifically check for the presence of more than one input sequence before delegating. Otherwise, it uses the functor implementation, including for the case of a lone sequence.