Skip to content
This repository has been archived by the owner on Sep 6, 2022. It is now read-only.

@nospell query? #58

Open
will opened this issue Jan 28, 2022 · 1 comment
Open

@nospell query? #58

will opened this issue Jan 28, 2022 · 1 comment

Comments

@will
Copy link
Contributor

will commented Jan 28, 2022

In general I'm very happy with the string spellchecking you just merged in #57, however it'd be nice if calls to require like require "shellwords" didn't spellcheck shellwords

I think I've been able to figure out a query works to find those regions:

(call
  method: (identifier) @method_name
  (#eq? @method_name "require")
  arguments: ( argument_list (string (string_content) @nospell))
)

(though it's my first not trivial query, so not 100% sure)

Do you think it's feasible to also mark things as not needing spellchecking? Or really, is this something you'd consider either adding or accepting at all in the first place?

@will will changed the title @nospell query @nospell query? Jan 28, 2022
@lewis6991
Copy link
Owner

I'm happy for us to implement something like @nospell (in the sense I would accept a PR) but we'd need to:

  1. Define exactly what it means and how it interacts with @spell. It might seem obvious, but it is more complex than you think.
  2. Actually implement it, which I'd imagine would be quite a bit more complicated than just @spell.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants