Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix invalid entry in agent_config dict in documentation #763

Closed
wants to merge 1 commit into from

Conversation

ifsheldon
Copy link
Contributor

Please describe the purpose of this pull request.
Fix invalid entry in agent_config dict in documentation. The example in python_client.md is broken due to changes from AgentConfigs.

How to test
You can test it with latest memgpt in main branch. And I suggest examples in documentation should be synced with test cases.

Have you tested this PR?
Yes, it runs with memgpt="0.2.10" in main branch. I ran it with installation from source.

Is your PR over 500 lines of code?
No

@cpacker cpacker changed the title Fix invalid entry in agent_config dict in documentation fix: Fix invalid entry in agent_config dict in documentation Jan 2, 2024
Copy link
Collaborator

@cpacker cpacker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching this!

@cpacker cpacker self-requested a review January 2, 2024 20:13
Copy link
Collaborator

@cpacker cpacker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it looks like there's a merge conflict likely due to a docs linting PR - can you either rebase this PR on main, merge in main into this PR, or recreate this PR on top of a fresh copy of main?

@cpacker
Copy link
Collaborator

cpacker commented Jan 3, 2024

#772

@cpacker cpacker closed this Jan 3, 2024
@ifsheldon ifsheldon deleted the doc_fix branch January 4, 2024 07:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants