Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: [446] better gitignore for IDEs and OS. #651

Merged
merged 4 commits into from
Dec 19, 2023

Conversation

agiletechnologist
Copy link
Contributor

Please describe the purpose of this pull request.
Is it to add a new feature? Is it to fix a bug?

How to test
How can we test your PR during review? What commands should we run? What outcomes should we expect?
Should ignore IDEs and OS files.

Have you tested this PR?
Have you tested the latest commit on the PR? If so please provide outputs from your tests.
Listing shows up without PyCharm exclusions not to be Added in git commands.

Related issues or PRs
(#446)

Is your PR over 500 lines of code?
Yes the .gitignore adds OS(Linux, Windows, macOs), IDE(PyCharm, VisualStudio, pydev, NetBeans, Eclipse) Other(vim, JupyterNotebooks)

@agiletechnologist agiletechnologist changed the title [446] better gitignore for IDEs and OS. fix: [446] better gitignore for IDEs and OS. Dec 19, 2023
@agiletechnologist
Copy link
Contributor Author

Tests are Failing on a nonrelated Error in tests regarding gitignore.
FAILED tests/test_websocket_interface.py::test_websockets - requests.exceptions.HTTPError: 401 Client Error: Unauthorized for url: https://api.openai.com/v1/chat/completions
============= 1 failed, 15 passed, 5 skipped, 2 warnings in 51.24s =============
Error: Process completed with exit code 1.

@cpacker cpacker self-requested a review December 19, 2023 22:28
Copy link
Collaborator

@cpacker cpacker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@cpacker cpacker merged commit 8aab782 into letta-ai:main Dec 19, 2023
1 of 2 checks passed
sarahwooders pushed a commit that referenced this pull request Dec 26, 2023
* [446] better gitignore for IDEs and OS.

* [446] better gitignore for IDEs and OS.
norton120 pushed a commit to norton120/MemGPT that referenced this pull request Feb 15, 2024
* [446] better gitignore for IDEs and OS.

* [446] better gitignore for IDEs and OS.
mattzh72 pushed a commit that referenced this pull request Oct 9, 2024
* [446] better gitignore for IDEs and OS.

* [446] better gitignore for IDEs and OS.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants