Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Separate out streaming route #2111

Merged
merged 11 commits into from
Nov 27, 2024
Merged

feat: Separate out streaming route #2111

merged 11 commits into from
Nov 27, 2024

Conversation

mattzh72
Copy link
Collaborator

@mattzh72 mattzh72 commented Nov 27, 2024 •
edited
Loading

Description

Separate out a messages route for streaming and one for non-streaming. Also deprecated the following fields:

  • return_message_object
  • use_assistant_message

Testing

Rely on existing tests to cover.

@sarahwooders
Copy link
Collaborator

sarahwooders commented Nov 27, 2024 •
edited
Loading

Should we also edit the schema of LettaResponse?

messages: List[Union[SystemMessage, UserMessage, InternalMonologue, FunctionCallMessage, FunctionReturn, AssistantMessage]]

usage: LettaUsageStatistics

@mattzh72 mattzh72 merged commit f23d436 into main Nov 27, 2024
29 of 30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sarahwooders sarahwooders sarahwooders approved these changes

@cpacker cpacker Awaiting requested review from cpacker

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mattzh72 @sarahwooders