WIP - Condense configurations into conventions for Database (Metadatastore) Adapters #1460
Commits on Jul 9, 2024
-
-
-
-
-
-
-
-
-
most of the initial config override in test_server
is working. Next up: - isolate the test_server failing tests - move the settings mock into a conftest fixture - add a test hook for SyncServer so you can do the same thing there. - propigate.
-
-
-
Removed duplication of constants/configs/envars
for default persona, human, and preset. Now all derived from settings (which is in turn derived from envars). Still need to square away with the config file hierarchy, so once we resolve the value there is only one definitive source of truth across the rest of the code.
-
-
Started a working README for refactor, so if I get
hit by a bus the next person doesn't need to spend a week getting up to speed. This helps clarify the goal in this PR: one config hierarchy assembled once, with one mega hook.
-
-
-
This is the basic 2 backend pattern.
TODO: - mount the test sqlite/chroma somewhere that doesn't clutter up the repo
-
-
-
-
I'm trying to keep this as close to the current model as possible whi…
…le stripping out extraneous elements. The memory thing needs to be abstracted in a later time, never clear if these are strings or templates or references to a related object
-
-
-
-
migrations now included on startup. we need to add it to every possib…
…le entrypoint to be good to go
-
-
configs pattern for now. these should be 1st class. also there needs …
…to be helpers like palm to do migrations and such
-
-
pg_uri is now the _only_ db setting. it will always have the correct …
…scheme. the settings.backend object is self-contained, so no more external double-setting
-
chewing through all the redundant crud methods in metadata to ideally…
… stub everything over to ORM models.
-
The big cutover to ORM begins! What's happening here:
1. the metadata.py file is being updated to use the ORM 2. conflicting models are being sunset and/or quarantined for this PR 3. CRUD accessors stay in metadatastore but are now managed behind the scenes by the ORM This is going to break a lot of things (which is goodTo get unbroken: 1. update the tests to no longer be aware of the backend configs 2. update the code to same 3. remove all the SQLModel and deprecated backend code 4. document (loom) how the ORM works, how to create migrations, how to traverse the ORM tree etc etc. Strategy here should be to merge this into a long-running branch and start CI against it, then keep pulling main into it until we're ready for a major release (this will be a major). Configs will be extremely thin after this PR. We should be set up to move docker dev to a single stack and docker quickstart to a single image.
-
-
-
stripped all the SQLModel, pydantic schemas vs dataclasses vs arb cla…
…sses still a mess, but I think we can get around that to get things working
-
-
-
Conftest ALMOST has a scoped test app so we can
stop spinning up servers in tests! But... 1. need to move the db_session all the way up to the request (where it belongs). 2. dep inject that thing at request time! 3. dep override it in conftest!
-
