Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

existing tools are removed from an agent with tools are updated #1828

Closed
sarahwooders opened this issue Oct 4, 2024 · 2 comments · Fixed by #1886 or #1898
Closed

existing tools are removed from an agent with tools are updated #1828

sarahwooders opened this issue Oct 4, 2024 · 2 comments · Fixed by #1886 or #1898
Labels
bug Something isn't working

Comments

@sarahwooders
Copy link
Collaborator

sarahwooders commented Oct 4, 2024

From a discord user:

When trying to create a new tool and add it to an already existing agent, the agent's tools are all wiped except for the added tool, I believe it is because tool adding is handled by the update_agent() function, which requires a list of tools to replace the original set of tools, I managed to mitigate this problem by getting the already added tools into this list as well as my new tool before updating it using that function using the python SDK. I believe this simple bugfix can also be applied to how the ADE behaves with tool handling by acquiring the agent's already added tools and adding them into the tools=[] list under the arguments for the update_agent() function.

@ketchalegend
Copy link

ketchalegend commented Oct 12, 2024

@sarahwooders Also I will like to add: I noticed this bug yesterday.

When you make changes to a tool using the ADE it seems to be saved. But doing a get request to the tools endpoint shows that the tool has the new code but the required fields are still are old ones from before the save. It seems like they never get updated until the tool is completely deleted and added again.

I defined new required fields in my function but the ai kept trying to call the function with old fields which no longer existed. I had to delete the tool using the restapi completely and create it again.

@sarahwooders sarahwooders linked a pull request Oct 15, 2024 that will close this issue
@github-project-automation github-project-automation bot moved this from To triage to Done in 🐛 MemGPT issue tracker Oct 15, 2024
@mattzh72
Copy link
Collaborator

we need @4shub to update the dev portal

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants