Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Outdated example for iterating through keyset in v2/jwk readme #970

Closed
jhiemstrawisc opened this issue Aug 31, 2023 · 2 comments
Closed
Assignees

Comments

@jhiemstrawisc
Copy link

I was working with the /v2/jwks package and following along the example under the header "Parse and use a JWK key:". It looks like the code in the example for iterating through a keyset might be leftover from v1, as it contains:
for it := set.Iterate(context.Background()); it.Next(context.Background()); {

This did not work for me, but using set.Keys(context.Background()) does work to return a functioning iterator. I realized this after reading the v1->v2 changelog. Am I correct in thinking this should be updated?

@lestrrat
Copy link
Collaborator

lestrrat commented Sep 1, 2023

Yes, it should be updated!

@lestrrat
Copy link
Collaborator

lestrrat commented Sep 1, 2023

I think #971 and #972 fixes this. Please reopen if this was not enough. Thanks for the headsup

@lestrrat lestrrat closed this as completed Sep 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants