Performance tuning (#1615)

[fredburger]

Performance tuning (#1615)

Various performance optimizations, without refactoring or messing up too much (hopefully?).

33% - 50% reduction in compilation time for bootstrap.less.

Compilation times for bootstrap.less:

Env.	Mode	1.5.0-master	1.5.0-perf-tune	% reduction
Node	lessc (single run)	719 ms	484 ms	-33%
Node	JIT'ed (8 runs)	509 ms	228 ms	-55%
FF	Browser	2198 ms	832 ms	-62%
Chrome	Browser	1092 ms	797 ms	-27%
IE9	Browser	1720 ms	965 ms	-44%

[lukeapage]

wow, some good work, I will spend some time looking through this and then merge. I had a quick glance through and didn't see anything scary.

[fredburger]

Cool, thx!

[oyejorge]

Yes!
I'm in the process of updating my less.php compiler to 1.5 and so far these changes are proving to be just as effective in php.

[lukeapage]

note to self, check this works with & {}

[peol]

I just tried this branch in a rather complex app I have (>350 less files with varying includes) and it processed them ~45% faster(!), 👍 to get this in.

[lukeapage]

I'm in the process of doing it. I may revert some of the micro
optimizations if they make the code harder to understand but the bigger
things that make most of the difference will stay.

[peol]

That's awesome. Let me know if you want me to try anything out.

Cheers

Sorry for being brief, I sent this from my phone.

/Andrée

On 9 dec 2013, at 21:35, Luke Page [email protected] wrote:

I'm in the process of doing it. I may revert some of the micro
optimizations if they make the code harder to understand but the bigger
things that make most of the difference will stay.

—
Reply to this email directly or view it on
GitHubhttps://github.com//pull/1625#issuecomment-30170711
.

[lukeapage]

thanks, this is committed.

I made a few rollbacks, mainly around the jshint boss option (now on) e.g.

var a;
if (a = blah()) {
}

and "micro" caching. I don't think they made a difference, I still see a good improvment in speed, so thanks.

[bedney]

Thank you fredburger for authoring these significant performance optimizations and to lukeapage for integrating them!

Great work!!