Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: inline deprecated npmlog util dependency #882

Merged
merged 9 commits into from
Jun 27, 2024
Merged

Conversation

ghiscoding
Copy link
Member

@ghiscoding ghiscoding commented Jun 23, 2024

Description

Replace deprecated npm packages, it partially follows Lerna's approach via their PR 4033

This PR is inlining `npmlog and other npm deprecated utils related to it

There are other npm utils that will be migrated in a separate PR since this PR is already quite large

Motivation and Context

On May 4th, 2024, without notice or warning, npm archived a few packages that Lerna-Lite depended on and in particular the npmlog package, let's reimplement it and update all packages to latest

How Has This Been Tested?

Types of changes

  • Chore (change that has absolutely no effect on users)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Copy link

codecov bot commented Jun 23, 2024

Codecov Report

Attention: Patch coverage is 98.09359% with 22 lines in your changes missing coverage. Please review.

Project coverage is 97.72%. Comparing base (1b78b53) to head (d84a777).

Files Patch % Lines
packages/npmlog/src/gauge/render-template.ts 94.59% 11 Missing ⚠️
packages/npmlog/src/gauge/set-immediate.ts 14.29% 6 Missing ⚠️
...ages/npmlog/src/are-we-there-yet/tracker-stream.ts 90.63% 3 Missing ⚠️
packages/npmlog/src/gauge/theme-set.ts 98.22% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #882      +/-   ##
==========================================
- Coverage   97.74%   97.72%   -0.02%     
==========================================
  Files         155      145      -10     
  Lines        7915     8873     +958     
  Branches     1929     2230     +301     
==========================================
+ Hits         7736     8670     +934     
- Misses        178      202      +24     
  Partials        1        1              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ghiscoding ghiscoding changed the title chore: replace npmlog with internal reimplementation of it fix: update npm utility dependencies and related packages Jun 25, 2024
@ghiscoding ghiscoding changed the title fix: update npm utility dependencies and related packages fix: inline deprecated npmlog util dependency Jun 25, 2024
@ghiscoding ghiscoding merged commit 9243e8e into main Jun 27, 2024
6 checks passed
@ghiscoding ghiscoding deleted the chore/update-npm-deps branch June 27, 2024 03:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant