Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better document the interaction of SsrModes with blocking resources #1765

Merged
merged 1 commit into from
Sep 22, 2023

Conversation

g2p
Copy link
Contributor

@g2p g2p commented Sep 21, 2023

Meant to address users making the same mistake as
#1119

@g2p
Copy link
Contributor Author

g2p commented Sep 21, 2023

By the way, I wonder if PartiallyBlocked might become the default. I don't see the point of having the expected HTML seemingly ready but hidden within an unrendered template.

@g2p g2p force-pushed the doc-partially-blocked branch from 409bdce to d71a04f Compare September 21, 2023 14:01
@gbj
Copy link
Collaborator

gbj commented Sep 22, 2023

Thanks! This is really helpful and looks accurate to me. PartiallyBlocked was added after this chapter was written, and I clearly didn't do a good job of explaining it. I appreciate the help.

@gbj gbj merged commit d651400 into leptos-rs:main Sep 22, 2023
55 checks passed
@gbj
Copy link
Collaborator

gbj commented Sep 22, 2023

By the way, I wonder if PartiallyBlocked might become the default. I don't see the point of having the expected HTML seemingly ready but hidden within an unrendered template.

It's purely a performance thing: PartiallyBlocked is really only useful in situations that do not support any JavaScript usage, including inline script tags, at the cost of an extra O(n) string replace on the server. I guess I'm open to argument in the other direction, but if you want to have that conversation we should do it in a separate discussion or issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants