Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Allow component names to be paths #1725

Merged
merged 2 commits into from
Sep 15, 2023

Conversation

mrvillage
Copy link
Contributor

Simply put, this allows you to do <module::Component /> on top of the existing <div /> and <Component /> style syntaxes.

@gbj
Copy link
Collaborator

gbj commented Sep 15, 2023

Great idea! I believe we technically do allow namespaced element names like <svg::a> to disambiguate between HTML and SVG elements in that very specific situation, so I believe this still does need to check the last path segment to see if it has an uppercase name if it's going to behave correctly.

@gbj gbj merged commit 2c12256 into leptos-rs:main Sep 15, 2023
55 checks passed
@gbj
Copy link
Collaborator

gbj commented Sep 15, 2023

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants