Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update to typed-builder 0.15 (closes #1455) #1496

Closed
wants to merge 2 commits into from
Closed

update to typed-builder 0.15 (closes #1455) #1496

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
665977d
update to `typed-builder` 0.15 (closes #1455)
gbj Aug 4, 2023
cd1d585
empty `#[builder()]` not allowed any more
gbj Aug 4, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion leptos/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ leptos_reactive = { workspace = true }
leptos_server = { workspace = true }
leptos_config = { workspace = true }
tracing = "0.1"
typed-builder = "0.14"
typed-builder = "0.15"
server_fn = { workspace = true }
web-sys = { version = "0.3.63", optional = true }
wasm-bindgen = { version = "0.2", optional = true }
Expand Down
2 changes: 1 addition & 1 deletion leptos_config/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ config = "0.13.3"
regex = "1.7.0"
serde = { version = "1.0.151", features = ["derive"] }
thiserror = "1.0.38"
typed-builder = "0.14"
typed-builder = "0.15"

[dev-dependencies]
tokio = { version = "1", features = ["rt", "macros"] }
Expand Down
2 changes: 1 addition & 1 deletion leptos_macro/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ tracing = "0.1.37"

[dev-dependencies]
log = "0.4"
typed-builder = "0.14"
typed-builder = "0.15"
trybuild = "1"
leptos = { path = "../leptos" }

Expand Down
6 changes: 3 additions & 3 deletions leptos_macro/src/component.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -561,9 +561,9 @@ impl ToTokens for TypedBuilderOpts {
quote! {}
};

let output = quote! { #[builder(#default #setter)] };

tokens.append_all(output);
if !default.is_empty() && !setter.is_empty() {
tokens.append_all(quote! { #[builder(#default #setter)] });
}
}
}

Expand Down