Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

benchmarks are borken #1736

Closed
fundon opened this issue Sep 16, 2023 · 0 comments · Fixed by #1771
Closed

benchmarks are borken #1736

fundon opened this issue Sep 16, 2023 · 0 comments · Fixed by #1771

Comments

@fundon
Copy link
Contributor

fundon commented Sep 16, 2023

Describe the bug

cargo bench
error[E0425]: cannot find function `create_scope` in this scope
  --> leptos_reactive/benches/deep_update.rs:83:13
   |
83 |               create_scope(runtime, |cx| {
   |               ^^^^^^^^^^^^
   |
  ::: /Volumes/Eva/Workspaces/Rust/viz/_leptos/leptos_reactive/src/slice.rs:72:1
   |
72 | / pub fn create_slice<T, O, S>(
73 | |     signal: RwSignal<T>,
74 | |     getter: impl Fn(&T) -> O + Clone + Copy + 'static,
75 | |     setter: impl Fn(&mut T, S) + Clone + Copy + 'static,
76 | | ) -> (Signal<O>, SignalSetter<S>)
77 | | where
78 | |     O: PartialEq,
   | |_________________- similarly named function `create_slice` defined here
   |
help: a function with a similar name exists
   |
83 |             create_slice(runtime, |cx| {
   |             ~~~~~~~~~~~~
help: consider importing one of these items
   |
1  + use l021::create_scope;
   |
1  + use sycamore::prelude::create_scope;
   |

error[E0061]: this function takes 1 argument but 2 arguments were supplied
    --> leptos_reactive/benches/deep_update.rs:84:30
     |
84   |                 let signal = create_rw_signal(cx, 0);
     |                              ^^^^^^^^^^^^^^^^   ---
     |                                                 | |
     |                                                 | unexpected argument of type `{integer}`
     |                                                 help: remove the extra argument
     |
note: function defined here
    --> /Volumes/Eva/Workspaces/Rust/viz/_leptos/leptos_reactive/src/signal.rs:1157:8
     |
1157 | pub fn create_rw_signal<T>(value: T) -> RwSignal<T> {
     |        ^^^^^^^^^^^^^^^^

error[E0061]: this function takes 1 argument but 2 arguments were supplied
  --> leptos_reactive/benches/deep_update.rs:89:36
   |
89 |                         memos.push(create_memo(cx, move |_| prev.get() + 1));
   |                                    ^^^^^^^^^^^   -------------------------
   |                                                  | |
   |                                                  | unexpected argument of type `[closure@leptos_reactive/benches/deep_update.rs:89:52: 89:60]`
   |                                                  help: remove the extra argument
   |
note: function defined here
  --> /Volumes/Eva/Workspaces/Rust/viz/_leptos/leptos_reactive/src/memo.rs:85:8
   |
85 | pub fn create_memo<T>(f: impl Fn(Option<&T>) -> T + 'static) -> Memo<T>
   |        ^^^^^^^^^^^

error[E0061]: this function takes 1 argument but 2 arguments were supplied
  --> leptos_reactive/benches/deep_update.rs:91:36
   |
91 |                         memos.push(create_memo(cx, move |_| signal.get() + 1));
   |                                    ^^^^^^^^^^^   ---------------------------
   |                                                  | |
   |                                                  | unexpected argument of type `[closure@leptos_reactive/benches/deep_update.rs:91:52: 91:60]`
   |                                                  help: remove the extra argument
   |
note: function defined here
  --> /Volumes/Eva/Workspaces/Rust/viz/_leptos/leptos_reactive/src/memo.rs:85:8
   |
85 | pub fn create_memo<T>(f: impl Fn(Option<&T>) -> T + 'static) -> Memo<T>
   |        ^^^^^^^^^^^

error[E0277]: expected a `std::ops::Fn<(std::option::Option<&usize>,)>` closure, found `{integer}`
  --> leptos_reactive/benches/deep_update.rs:89:48
   |
89 |                         memos.push(create_memo(cx, move |_| prev.get() + 1));
   |                                    ----------- ^^ expected an `Fn<(std::option::Option<&usize>,)>` closure, found `{integer}`
   |                                    |
   |                                    required by a bound introduced by this call
   |
   = help: the trait `for<'a> std::ops::Fn<(std::option::Option<&'a usize>,)>` is not implemented for `{integer}`
note: required by a bound in `leptos::create_memo`
  --> /Volumes/Eva/Workspaces/Rust/viz/_leptos/leptos_reactive/src/memo.rs:85:31
   |
85 | pub fn create_memo<T>(f: impl Fn(Option<&T>) -> T + 'static) -> Memo<T>
   |                               ^^^^^^^^^^^^^^^^^^^ required by this bound in `create_memo`

error[E0277]: expected a `std::ops::Fn<(std::option::Option<&usize>,)>` closure, found `{integer}`
  --> leptos_reactive/benches/deep_update.rs:91:48
   |
91 |                         memos.push(create_memo(cx, move |_| signal.get() + 1));
   |                                    ----------- ^^ expected an `Fn<(std::option::Option<&usize>,)>` closure, found `{integer}`
   |                                    |
   |                                    required by a bound introduced by this call
   |
   = help: the trait `for<'a> std::ops::Fn<(std::option::Option<&'a usize>,)>` is not implemented for `{integer}`
note: required by a bound in `leptos::create_memo`
  --> /Volumes/Eva/Workspaces/Rust/viz/_leptos/leptos_reactive/src/memo.rs:85:31
   |
85 | pub fn create_memo<T>(f: impl Fn(Option<&T>) -> T + 'static) -> Memo<T>
   |                               ^^^^^^^^^^^^^^^^^^^ required by this bound in `create_memo`

Some errors have detailed explanations: E0061, E0277, E0425.
For more information about an error, try `rustc --explain E0061`.
error: could not compile `leptos_reactive` (bench "deep_update") due to 6 previous errors
warning: build failed, waiting for other jobs to finish..
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant