Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reconsider object model getter helpers #45

Open
leonhard-s opened this issue Apr 11, 2021 · 0 comments
Open

Reconsider object model getter helpers #45

leonhard-s opened this issue Apr 11, 2021 · 0 comments
Labels
discussion Additional opinions wanted enhancement New feature or request prio:normal No immediate action required

Comments

@leonhard-s
Copy link
Owner

Relational tables like characters_item are currently exposed via a provisional interface that effectively wraps a census.Query object with an anonymous **kwargs annotation. This makes them difficult to use, while still not featuring the full join capabilities of the underlying query.

Since this system was introduced, the URL generator has been promoted to be part of the main API. It would therefore be possible to just turn these into query factories, then have the user perform the request.

Alternatively, these methods need to be extended with useful argument types to make them easier to use. Users who want to use the lower-level Query interface can always generate a query to a given instance via the .query() factory and then join away as per the census module API.

@leonhard-s leonhard-s added enhancement New feature or request discussion Additional opinions wanted prio:normal No immediate action required labels Apr 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discussion Additional opinions wanted enhancement New feature or request prio:normal No immediate action required
Projects
None yet
Development

No branches or pull requests

1 participant