Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merging overlapping tooltip position is off #1217

Closed
bjarnef opened this issue Aug 2, 2022 · 5 comments
Closed

Merging overlapping tooltip position is off #1217

bjarnef opened this issue Aug 2, 2022 · 5 comments

Comments

@bjarnef
Copy link

bjarnef commented Aug 2, 2022

When merging overlapping tooltips was introduced it looked great #1032
https://refreshless.com/nouislider/examples/#section-merging-tooltips

But it seems something has changed in recent updates as the position is off.

The example here is based on v15.6.0

chrome_0D6VrS22Jd.mp4

When I revert back to v15.4.0 it starts working again.

chrome_RQzlmNp2Xz.mp4

Not sure which change broke this feature though, but it seems to be related to one on the changes v15.5.0 where I could reproduce the issue as well.

@bjarnef bjarnef changed the title Merging overlapping tooltips doesn't look correct anymore Merging overlapping tooltip position is off Aug 2, 2022
@leongersen
Copy link
Owner

This is an unfortunate side effect of a compatibility fix in 15.5.0.

TLDR: these changes in the default stylesheet need to be incorporated in your overriding styles.

See #1167 for more discussion on this.

@bjarnef
Copy link
Author

bjarnef commented Aug 3, 2022

Yes, we include the nouislider.min.css and overwrite a bit of the styling.
But not regarding height and width on .@{noUi-css-prefix}-connect and .@{noUi-css-prefix}-origin

a1f8f17

When I remove the custom stylesheet overwriting the default CSS I still get this:

chrome_3MRYbETrLe.mp4

What am I missing?

@leongersen
Copy link
Owner

The example on merging overlapping tooltips was also updated to accommodate for the sizing changes, you'll want to upgrade that, too. I'll make sure to flag that in the changelog.

@bjarnef
Copy link
Author

bjarnef commented Aug 3, 2022

@leongersen yes, that was it. Thanks! 😁

I also originally added this: #1032 (comment)
So if handle A and handle B are located at same value there is only a single value in tooltip.

image

In the example it looks like this:

image

@github-actions
Copy link

github-actions bot commented Sep 4, 2022

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 4, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants