Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[leo_storage][leo_mq] A replication request can be blocked for 30 seconds #728

Open
mocchira opened this issue May 10, 2017 · 3 comments
Open

Comments

@mocchira
Copy link
Member

Found through discussions on #702.
Reference: #702 (comment)

This can be reduced by

@mocchira
Copy link
Member Author

It turned out that now

  • No info which nodes send a successful reply
  • SubParent calling the loop function holds the result and state (how many successes are there and so on).

That said, more tweaks will be needed to fix this issue.

  • Grasp which nodes send a successful reply
  • Add the node info to the message sent from callees

@mocchira
Copy link
Member Author

mocchira commented Feb 28, 2018

Now https://github.com/leo-project/leo_konsul (leo_redundant_manager replacement) has been under active development and once this works finished, we may be able to fix this issue in a more easy way like below

    % Add the code below into where waiting for responses from recipients
    {ok, Ref} = leo_konsul:subscribe_on_node_state_change(self()),
    receive
        {Ref, node_state_change, Node, _PrevState, stop} ->
            % Give up waiting for the response from Node ...
    after ->
        % ...
    end,

We will postpone this issue to 1.4.1 once it turns out that the above idea can be feasible.

@yosukehara yosukehara modified the milestones: 1.4.0, 1.4.1 Mar 6, 2018
@mocchira
Copy link
Member Author

Since leo_konsul will be introduced on 2.0.0, this issue depending on it also should postpone to 2.0.0.

@mocchira mocchira modified the milestones: 1.4.1, 2.0.0 Mar 23, 2018
@yosukehara yosukehara removed the v1.4 label Feb 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants