Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[leo_backend_db][eleveldb] Iterator-handler can be leaked #712

Closed
mocchira opened this issue Apr 20, 2017 · 1 comment
Closed

[leo_backend_db][eleveldb] Iterator-handler can be leaked #712

mocchira opened this issue Apr 20, 2017 · 1 comment

Comments

@mocchira
Copy link
Member

While tackling #710 , I noticed there is a bug that causes an iterator handle to leak.
Once we call eleveldb:iterator, we must call eleveldb:iterator_close/1 (https://github.com/basho/eleveldb/blob/2.0.34/src/eleveldb.erl#L246-L250) otherwise the iterator handle is leaked.

TOBE

Should be implemented with try after manner like the below.

@mocchira mocchira added this to the 1.3.3 milestone Apr 20, 2017
@mocchira mocchira self-assigned this Apr 20, 2017
@mocchira mocchira changed the title [leo_backend_db] iterator handle can be leaked [leo_backend_db][eleveldb] iterator handle can be leaked Apr 20, 2017
@mocchira
Copy link
Member Author

Note: The problem exists only at leo_backend_db_eleveldb.
(leo_backend_db_bitcask has been properly implemented)

@yosukehara yosukehara changed the title [leo_backend_db][eleveldb] iterator handle can be leaked [leo_backend_db][eleveldb] Iterator-handler can be leaked Apr 28, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants