Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Properly clone tuples #358

Merged
merged 7 commits into from
Mar 3, 2024
Merged

Properly clone tuples #358

merged 7 commits into from
Mar 3, 2024

Conversation

mdekstrand
Copy link
Member

The util.clone function incorrectly cloned tuples as lists. Fixed in 0.14.4, cross-porting to next release.

@mdekstrand mdekstrand added the bug Something isn't working label Feb 16, 2024
@mdekstrand mdekstrand added this to the 2024.1 milestone Feb 16, 2024
Copy link

codecov bot commented Mar 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.98%. Comparing base (3a0a0dc) to head (47ac74a).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #358      +/-   ##
==========================================
- Coverage   91.00%   90.98%   -0.03%     
==========================================
  Files          40       40              
  Lines        3125     3127       +2     
==========================================
+ Hits         2844     2845       +1     
- Misses        281      282       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mdekstrand mdekstrand merged commit 999b588 into lenskit:main Mar 3, 2024
16 of 17 checks passed
@mdekstrand mdekstrand deleted the fix/util-clone branch March 3, 2024 23:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant