Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use system helm instead the packaged one #2215

Open
ogarcia opened this issue Feb 24, 2021 · 6 comments
Open

Use system helm instead the packaged one #2215

ogarcia opened this issue Feb 24, 2021 · 6 comments
Labels
enhancement New feature or request

Comments

@ogarcia
Copy link

ogarcia commented Feb 24, 2021

What would you like to be added:
A new config entry to set the path to helm binary.

Why is this needed:
Because you can provide more tiny application that don't need to include a 47MB binary.

Environment you are Lens application on:

  • Kubernetes distribution: AKS
  • Desktop OS: Arch Linux
@ogarcia ogarcia added the enhancement New feature or request label Feb 24, 2021
@Nokel81
Copy link
Collaborator

Nokel81 commented Mar 25, 2021

Do you mean a setting similar to the one for kubectl or an option for not bundling helm3 with Lens?

@ogarcia
Copy link
Author

ogarcia commented Mar 25, 2021

Now I'm building package without helm using this:

make node_modules
make build-extensions
yarn dist:dir

But the only method that I found to avoid to have a copy of helm with lens is make a symlink into resources/helm3/helm3 of my /usr/bin/helm. I think that an option like the one for kubectl is a great solution.

You can see my hack in Arch Linux pkgbuild.

@clain23
Copy link

clain23 commented Dec 9, 2021

Using built-in helm on M1 mac results an error:

/Applications/Lens.app/Contents/Resources/helm3/helm3: Bad CPU type in executable

Standalone helm works fine.

@Nokel81
Copy link
Collaborator

Nokel81 commented Dec 9, 2021

@jakolehm Can you investigate the "bad CPU type" issue?

@ogarcia
Copy link
Author

ogarcia commented Dec 9, 2021

This is caused because M1 has ARM architecure and in you must package the x86_64 binary in Lens.

@Nokel81
Copy link
Collaborator

Nokel81 commented Dec 9, 2021

@ogarcia Yes, but in #3700 shouldn't have introduced it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants