fix: Webhooks trigger render error #215
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
taorepoara
reviewed
Mar 1, 2024
|
You should add a unit test to make sure that the problem won't come back |
taorepoara
approved these changes
Mar 12, 2024
|
🎉 This PR is included in version 1.2.1 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
taorepoara
added a commit
that referenced
this pull request
Sep 16, 2024
This reverts commit 45d2168.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About this PR
Closes #214
The problem was coming from the fact that we did not have a default View to render our controller results. I simply added the default view BaseView from the lenra_common lib and now it properly works. No error is shown in the console when triggering a webhook.
I've also added a default error view "FallbackController" just in case.
Technical highlight/advice
How to test my changes
Checklist
I included unit tests that cover my changes
I added/updated the documentation about my changes