Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Open external links on navto #188

Merged
merged 1 commit into from
May 31, 2023
Merged

feat: Open external links on navto #188

merged 1 commit into from
May 31, 2023

Conversation

jonas-martinez
Copy link
Collaborator

@jonas-martinez jonas-martinez commented May 30, 2023

Closes #

Description of the changes

Checklist

  • I didn't over-scope my PR
  • My PR title matches the commit convention
  • I did not include breaking changes
  • I made my own code-review before requesting one

I included unit tests that cover my changes

  • 👍 yes
  • 🙅 no, because they aren't needed
  • 🙋 no, because I need help

I added/updated the documentation about my changes

  • 📜 README.md
  • 📕 docs/*.md
  • 📓 docs.lenra.io
  • 🙅 no documentation needed

Technical highlight/advice

@jonas-martinez jonas-martinez self-assigned this May 30, 2023
@jonas-martinez jonas-martinez added the enhancement New feature or request label May 30, 2023
@jonas-martinez jonas-martinez changed the base branch from beta to alpha May 30, 2023 13:59
@jonas-martinez
Copy link
Collaborator Author

Uncaught MissingPluginException(No implementation found for method launch on channel plugins.flutter.io/url_launcher)

@jonas-martinez
Copy link
Collaborator Author

@jonas-martinez
Copy link
Collaborator Author

It seems to work now, I needed to run a flutter clean before the flutter build web. Apparently this is a known issue on Flutter and this is the fix.

@jonas-martinez jonas-martinez requested a review from taorepoara May 30, 2023 14:48
Copy link
Member

@taorepoara taorepoara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems OK

@taorepoara
Copy link
Member

I'll test it this afternoon

@taorepoara taorepoara merged commit e33c690 into alpha May 31, 2023
@taorepoara taorepoara deleted the open-links-on-navto branch May 31, 2023 12:46
@shiipou
Copy link
Contributor

shiipou commented May 31, 2023

🎉 This PR is included in version 1.0.0-alpha.6 🎉

The release is available on:

Your semantic-release bot 📦🚀

taorepoara added a commit that referenced this pull request Jun 8, 2023
* feat: Lenra Application Routes (#178)

* This should fix a lot

* This is working !!!

* update deps

* Update application runner

* feat: Update dependencies

* ci: Releases alpha

* feat: Update dependencies

* feat: Update dependencies

* feat: Update dependencies

* fix: Error when building client (no tree shake)

* feat: Client on port 4000 and API on 4001 (#187)

* feat: Open external links on navTo (#188)

* feat: Update dependencies (#189)

* build(deps): beta deps

---------

Co-authored-by: Thomas DA ROCHA <[email protected]>
taorepoara added a commit that referenced this pull request Oct 8, 2023
* feat: Lenra Application Routes (#178)

* This should fix a lot

* This is working !!!

* update deps

* Update application runner

* feat: Update dependencies

* ci: Releases alpha

* feat: Update dependencies

* feat: Update dependencies

* feat: Update dependencies

* fix: Error when building client (no tree shake)

* feat: Client on port 4000 and API on 4001 (#187)

* feat: Open external links on navTo (#188)

* feat: Update dependencies (#189)

* build(deps): beta deps

---------

Co-authored-by: Thomas DA ROCHA <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request released on @alpha
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants