-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use Minio for s3 integration tests in CI #18
Comments
@Daenyth sorry for how long it took to respond to this. Thanks for suggesting minio, it was super easy to set up with docker compose. In the end I chose to remove the We still have |
@Daenyth fixed SFTP container issue by telling amotz/sftp container to create root tests dir inside the container per atmoz/sftp#37 (comment) Figured this out thanks to travis support enabling debug mode in the project. Thanks again for the help. |
Glad I could help! I'm excited for the improvement to the project :) |
I'm willing to send this in as a PR. How do you want it? One travis build that does the current behavior + s3 tests?
I think the alternate approach might be to move the integration tests to
src/e2e
so they can be invoked separately more easily, and have two travis builds, one for test and one for e2e - the downside to this approach is that it makes coverage collection more complex.The text was updated successfully, but these errors were encountered: